Skip to content

ITP-25 LON | MIKIYAS GEBREMICHAEL | MODULE-DATA-FLOWS | Programmer Humour- Mini API project | SPRINT-3 / WEEK-3 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

ITP-25 LON | MIKIYAS GEBREMICHAEL | MODULE-DATA-FLOWS | Programmer Humour- Mini API project | SPRINT-3 / WEEK-3 #175

wants to merge 6 commits into from

Conversation

Mikiyas-STP
Copy link

@Mikiyas-STP Mikiyas-STP commented Mar 27, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Mikiyas-STP Mikiyas-STP added the Needs Review Participant to add when requesting review label Mar 27, 2025
halilibrahimcelik
halilibrahimcelik requested changes Apr 3, 2025
View reviewed changes
@halilibrahimcelik halilibrahimcelik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 3, 2025
halilibrahimcelik
halilibrahimcelik approved these changes Apr 8, 2025
View reviewed changes
Copy link

@halilibrahimcelik halilibrahimcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor adjustment to code apart from that, it is good to go well done

@halilibrahimcelik halilibrahimcelik added Reviewed Volunteer to add when completing a review Complete Participant to add when work is complete and review comments have been addressed and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 8, 2025
@Mikiyas-STP
Copy link
Author

Thank you for your feedbacks @halilibrahimcelik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halilibrahimcelik halilibrahimcelik halilibrahimcelik approved these changes

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikiyas-STP @halilibrahimcelik